feat: add sentry panic reporting #1089
Conversation
autopush_rs/src/server/mod.rs
Outdated
| .expect("Invalid Sentry DSN specified"); | ||
| let mut core = Core::new().expect("Unable to create core"); | ||
| let sentry = sentry::Sentry::from_settings(core.handle(), Default::default(), creds); | ||
| sentry.register_panic_handler(Some(|_: &PanicInfo| -> () {})); |
There was a problem hiding this comment.
I think that the empty callback here may mean that a panic doesn't actually get logged to stdout/stderr, but maybe it'd be good to print something briefly or run the default panic handler perhaps? (just in case)
|
Just a note, this does not retain the JoinHandle for the new Sentry thread. For a future issue where we fix the exit to be graceful, the Join handle for the thread will need to be retained somewhere so it can be join'd on graceful shutdown. |
bbangert
force-pushed
the
feat/issue-1066
branch
from
b033ba1 to
66554d9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1089 +/- ##
=======================================
Coverage 99.71% 99.71%
=======================================
Files 58 58
Lines 9264 9264
=======================================
Hits 9238 9238
Misses 26 26Continue to review full report at Codecov.
|
Closes #1066