Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

1.39.1 candidate -> release/1.39 #1082

Merged
merged 8 commits into from
Nov 20, 2017
Merged

Conversation

pjenvey
Copy link
Member

@pjenvey pjenvey commented Nov 20, 2017

This would be a 1.39.1 sans the boto3 integration and the small rust metrics addition.

Fast-forwarded to fa47b5c and cherry picked everything else. Had one minor conflict in test_endpoint.test_delete_db_error w/ an easy fix.

@pjenvey pjenvey requested review from jrconlin and bbangert November 20, 2017 00:14
@codecov-io
Copy link

codecov-io commented Nov 20, 2017

Codecov Report

Merging #1082 into release/1.39 will decrease coverage by 0.01%.
The diff coverage is 99.2%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release/1.39    #1082      +/-   ##
================================================
- Coverage         99.75%   99.73%   -0.02%     
================================================
  Files                56       58       +2     
  Lines              8888     9063     +175     
================================================
+ Hits               8866     9039     +173     
- Misses               22       24       +2
Impacted Files Coverage Δ
autopush/router/gcmclient.py 100% <100%> (ø)
autopush/router/gcm.py 100% <100%> (ø) ⬆️
autopush/router/apnsrouter.py 100% <100%> (ø) ⬆️
autopush/web/webpush.py 100% <100%> (ø) ⬆️
autopush/tests/test_integration.py 100% <100%> (ø) ⬆️
autopush/tests/test_gcmclient.py 100% <100%> (ø)
autopush/tests/test_router.py 100% <100%> (ø) ⬆️
autopush/tests/test_web_webpush.py 100% <100%> (ø) ⬆️
autopush/ssl.py 96.07% <50%> (-3.93%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ef57a2...443c368. Read the comment docs.

@pjenvey pjenvey merged commit 3412b9a into release/1.39 Nov 20, 2017
@pjenvey pjenvey deleted the release/1.39.1-integration branch November 20, 2017 05:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants