This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: migrate route info to expiring table #1079
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1079 +/- ##
==========================================
+ Coverage 99.71% 99.74% +0.03%
==========================================
Files 58 58
Lines 9131 9441 +310
==========================================
+ Hits 9105 9417 +312
+ Misses 26 24 -2
Continue to review full report at Codecov.
|
pjenvey
suggested changes
Nov 16, 2017
| write_throughput=5): | ||
| # type: (str, int, int) -> Table | ||
| write_throughput=5, expires=False, | ||
| migrate_tablename=None): |
| # type: (Callable[[str, int, int], Table], str, int, int) -> Table | ||
| def _make_table(table_func, tablename, read_throughput, write_throughput, | ||
| expires=True): | ||
| # type: (Callable[[str, int, int, bool], Table], str, int, int, bool) -> Table # noqa |
There was a problem hiding this comment.
was this # noqa intended here (is it doing something for mypy? isn't it just for flake8 which ignores this comment?)
tempted to kill this func entirely since it's only used once, but maybe we'll want to use it for the new message table later. we could also assume table_func takes kwargs (they do) and make it pass through **kwargs to it
|
Closing this PR due to age and OBE. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1051