Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

feat: convert to use AWS boto3 #1061

Merged
merged 1 commit into from
Nov 3, 2017
Merged

feat: convert to use AWS boto3 #1061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ install:
- pip install tox ${CODECOV:+codecov}
- if [ ${WITH_RUST:-true} != "false" ]; then curl https://sh.rustup.rs | sh -s -- -y || travis_terminate 1; fi
- export PATH=$PATH:$HOME/.cargo/bin
- export AWS_SHARED_CREDENTIALS_FILE=./automock/credentials.cfg
- export BOTO_CONFIG=./automock/boto.cfg
script:
- tox -- ${CODECOV:+--with-coverage --cover-xml --cover-package=autopush}
after_success:
Expand Down
8 changes: 5 additions & 3 deletions automock/boto.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
[Credentials]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we should kill this entire file now, boto3 only reads "Credentials" from a BOTO_CONFIG (which it considers an old boto2 config file).

Also if we're no longer able to configure our local dynamodb through this file our docker-compose setup will no longer work. I think that's a whole separate issue entirely from this PR, though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, going to hardcode the credentials, since they're bogus anyway and we only need them for the test.

aws_access_key_id =
aws_secret_access_key =
[default]

[Boto]
is_secure = False
https_validate_certificates = False
proxy_port = 8000
proxy = 127.0.0.1

[DynamoDB]
region=us-east-1
validate_checksums=False
3 changes: 3 additions & 0 deletions autopush/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
__version__ = '1.39.0' # pragma: nocover

# Max DynamoDB record lifespan (~ 30 days)
MAX_EXPIRY = 2592000 # pragma: nocover
Loading