Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Enforce senderID requirement for GCM/FCM records #868

Closed
jrconlin opened this issue Apr 12, 2017 · 0 comments · Fixed by #869
Closed

Enforce senderID requirement for GCM/FCM records #868

jrconlin opened this issue Apr 12, 2017 · 0 comments · Fixed by #869
Assignees

Comments

@jrconlin
Copy link
Member

We've seen a few reports of *cm records that do not include a senderID in their router data.
https://sentry.prod.mozaws.net/operations/autopush-prod/issues/358097/events/9996820/
We should consider those records to be a critical failure and mark them appropriately.

NOTE: This may disable notifications to this client, but they weren't getting through anyway.

@jrconlin jrconlin self-assigned this Apr 12, 2017
jrconlin added a commit that referenced this issue Apr 13, 2017
jrconlin added a commit that referenced this issue Apr 13, 2017
jrconlin added a commit that referenced this issue Apr 13, 2017
jrconlin added a commit that referenced this issue Apr 13, 2017
jrconlin added a commit that referenced this issue Apr 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants