Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

git sign commits #759

Closed
pjenvey opened this issue Dec 9, 2016 · 2 comments
Closed

git sign commits #759

pjenvey opened this issue Dec 9, 2016 · 2 comments
Assignees
@bbangert
Labels
enhancement p2
Milestone
PUSHSVC-0: quality

Comments

@pjenvey
Copy link
Member

pjenvey commented Dec 9, 2016 •
edited by bbangert
Loading

cloud ops security recommends signing all git commits, though admittedly that can be too strict for outside contributions. At the very least they recommend git signing tags.
@pjenvey pjenvey added this to the PUSHSVC-0: quality milestone Dec 9, 2016
@bbangert
Copy link
Member

bbangert commented Jan 6, 2017

I've begun signing all my commits.

@pjenvey
Copy link
Member Author

pjenvey commented Jan 11, 2017

we can close this out by adding a "strong recommendation" to git sign in CONTRIBUTING

@bbangert bbangert added in progress and removed ready labels Feb 6, 2017
@bbangert bbangert self-assigned this Feb 6, 2017
bbangert added a commit to mozilla-services/push-service that referenced this issue Feb 7, 2017
@bbangert
docs: note use of signed commits
8bd81e1 
Issue mozilla-services/autopush#759
bbangert added a commit that referenced this issue Feb 7, 2017
@bbangert
docs: add git signing note
dbf5249 
Closes #759
@bbangert bbangert mentioned this issue Feb 7, 2017
Merged
pjenvey added a commit that referenced this issue Feb 10, 2017
@pjenvey
docs: git tag needs an explicit signing flag
cc23b20 
issue #759
pjenvey added a commit that referenced this issue Feb 10, 2017
@pjenvey
docs: git tag needs an explicit signing flag (and msg)
e8b4782 
issue #759
@pjenvey pjenvey mentioned this issue Feb 10, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbangert bbangert

Labels
enhancement p2
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

No branches or pull requests
2 participants
@pjenvey @bbangert