Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Add mypy compatible type hints #712

Closed
bbangert opened this issue Oct 15, 2016 · 5 comments
Closed

Add mypy compatible type hints #712

bbangert opened this issue Oct 15, 2016 · 5 comments

Comments

@bbangert
Copy link
Member

bbangert commented Oct 15, 2016

We should add mypy compatible type hints throughout the code-base.

@bbangert bbangert added this to the PUSHSVC-0: quality milestone Oct 15, 2016
bbangert added a commit that referenced this issue Oct 15, 2016
bbangert added a commit that referenced this issue Oct 15, 2016
bbangert added a commit that referenced this issue Oct 15, 2016
bbangert added a commit that referenced this issue Oct 17, 2016
@bbangert bbangert added the ready label Oct 17, 2016
bbangert added a commit that referenced this issue Oct 17, 2016
bbangert added a commit that referenced this issue Oct 17, 2016
@bbangert bbangert added p1 p2 and removed p2 p1 labels Nov 14, 2016
pjenvey added a commit that referenced this issue Nov 24, 2016
and add type hints to crypto_key

closes #750, issue #712
pjenvey added a commit that referenced this issue Nov 24, 2016
and add type hints to crypto_key

closes #750, issue #712
bbangert pushed a commit that referenced this issue Nov 28, 2016
and add type hints to crypto_key

closes #750, issue #712
pjenvey added a commit that referenced this issue Feb 11, 2017
and try running mypy on travis

issue #712
pjenvey added a commit that referenced this issue Feb 11, 2017
and try running mypy on travis

issue #712
pjenvey added a commit that referenced this issue Feb 11, 2017
and try running mypy on travis

issue #712
pjenvey added a commit that referenced this issue Feb 11, 2017
and try running mypy on travis

issue #712
pjenvey added a commit that referenced this issue Feb 11, 2017
and try running mypy on travis

issue #712
pjenvey added a commit that referenced this issue Feb 11, 2017
and try running mypy on travis

issue #712
@bbangert bbangert added p3 and removed p2 labels Mar 13, 2017
@ghost ghost added the good first bug label Mar 28, 2017
@pjenvey pjenvey removed the ready label Apr 12, 2017
@pjenvey pjenvey self-assigned this Apr 13, 2017
@abdulhannanali
Copy link

@pjenvey @bbangert Haven't done python but would ❤️ to take a shot on this. Is this still available?

@bbangert
Copy link
Member Author

@abdulhannanali we have added some slowly over time as we go through code, but yes, this is still available as its lacking in many places. I believe @pjenvey has a large refactor of settings/config stuff, so probably want to stay out of that spot for now.

@pjenvey
Copy link
Member

pjenvey commented Oct 19, 2017

With some effort we could get mypy's tox run succeeding sooner rather than later by building on wsanchez's shell script:

https://github.com/burningmantech/ranger-ims-server/blob/master/bin/mypy

@jrconlin
Copy link
Member

and then there are all the fun dynamically created classes that boto3 brings to the party...

@bbangert
Copy link
Member Author

Closing this as it isn't a priority for maintenance mode and we can add types as it comes up in existing work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants