Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

JSONResponseError: 400 Bad Request #703

Closed
bbangert opened this issue Oct 13, 2016 · 3 comments · Fixed by #718
Closed

JSONResponseError: 400 Bad Request #703

bbangert opened this issue Oct 13, 2016 · 3 comments · Fixed by #718
Assignees
@pjenvey
Labels
bug p1
Milestone
PUSHSVC-0: quality

Comments

@bbangert
Copy link
Member

Occasionally requests have a token error, these should be caught since they're not addressable bugs.

Most likely in track_provisioned so they can be logged out appropriately for ops to look at if desired.

See: https://sentry.prod.mozaws.net/operations/autopush-prod/issues/358013/
@bbangert bbangert added this to the PUSHSVC-0: quality milestone Oct 13, 2016
@bbangert bbangert added the ready label Oct 17, 2016
@pjenvey
Copy link
Member

pjenvey commented Oct 17, 2016

Updated sentry link: https://sentry.prod.mozaws.net/operations/autopush-prod/issues/358260/

@pjenvey pjenvey self-assigned this Oct 18, 2016
@pjenvey pjenvey added in progress and removed ready labels Oct 18, 2016
@pjenvey
Copy link
Member

pjenvey commented Oct 18, 2016

I see sentry entries for db calls: all_channels, fetch_messages, fetch_notifications, register_user

These come from websocket. endpoint/web.base already traps the parent BotoServerError

track_provisioned should increase a metric and reraise, then websocket can handle as it likes

pjenvey added a commit that referenced this issue Oct 20, 2016
@pjenvey
fix: improve handling of JSONResponseErrors
0177afc 
have websocket log them instead of passing along to sentry and give them
a metric

closes #703
@pjenvey pjenvey mentioned this issue Oct 20, 2016
Merged
pjenvey added a commit that referenced this issue Oct 20, 2016
@pjenvey
fix: improve handling of JSONResponseErrors
94765fa 
have websocket log them instead of passing along to sentry and give them
a metric

closes #703
pjenvey added a commit that referenced this issue Oct 20, 2016
@pjenvey
fix: improve handling of JSONResponseErrors
8cbe294 
have websocket log them instead of passing along to sentry and give them
a metric

closes #703
@pjenvey
Copy link
Member

pjenvey commented Oct 20, 2016

actually any db call can trigger this

https://sentry.prod.mozaws.net/operations/autopush-prod/issues/360478/

pjenvey added a commit that referenced this issue Oct 20, 2016
@pjenvey
fix: improve handling of JSONResponseErrors
40ec280 
have websocket log them instead of passing along to sentry and give them
a metric

closes #703
pjenvey added a commit that referenced this issue Oct 20, 2016
@pjenvey
fix: improve handling of JSONResponseErrors
ce4c79d 
have websocket log them instead of passing along to sentry and give them
a metric

closes #703
bbangert pushed a commit that referenced this issue Oct 20, 2016
@pjenvey @bbangert
fix: improve handling of JSONResponseErrors (#718)
29ff0fe 
have websocket log them instead of passing along to sentry and give them
a metric

closes #703
jrconlin pushed a commit that referenced this issue Oct 21, 2016
@pjenvey @jrconlin
fix: improve handling of JSONResponseErrors (#718)
a9a660e 
have websocket log them instead of passing along to sentry and give them
a metric

closes #703
jrconlin added a commit that referenced this issue Oct 21, 2016
@jrconlin
fix: improve handling of JSONResponseErrors (#718)
8a34512 
have websocket log them instead of passing along to sentry and give them
a metric

closes #703
jrconlin added a commit that referenced this issue Oct 21, 2016
@jrconlin
fix: improve handling of JSONResponseErrors
7dcb0a0 
have websocket log them instead of passing along to sentry and give them
a metric

closes #703
@pjenvey pjenvey mentioned this issue Nov 22, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjenvey pjenvey

Labels
bug p1
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

Successfully merging a pull request may close this issue.

fix: improve handling of JSONResponseErrors mozilla-services/autopush
2 participants
@pjenvey @bbangert