Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

bug: Fix header parsing for Autopush #410

Closed
jrconlin opened this issue Mar 16, 2016 · 0 comments
Closed

bug: Fix header parsing for Autopush #410

jrconlin opened this issue Mar 16, 2016 · 0 comments
Assignees
@jrconlin
Milestone
PUSHSVC-0: quality

Comments

@jrconlin
Copy link
Member

http://tools.ietf.org/html/draft-ietf-httpbis-encryption-encoding-00#section-5.3
notes that Crypto-Key components have the following
keyid="id";tag="value",keyid="id";tag="value";...

Since headers tend to have specific relationships with the data that they are encoding, parse_header needs to comply with the Crypto-Key format, and all references to the header output will need to be refactored.
@marco-c marco-c mentioned this issue Mar 16, 2016
Merged
4 tasks
@bbangert bbangert added this to the PUSHSVC-0: quality milestone Mar 16, 2016
@bbangert bbangert added the ready label Mar 16, 2016
jrconlin added a commit that referenced this issue Mar 16, 2016
@jrconlin
bug: decode and process crypto-key header correctly
1866025 
The Crypto-Key header has a different format than what was first
understood. A valid Crypto-Key header may look like `keyid="foo";
key1="data",key2="data"`. This patch specialized Crypto-Key parsing
to a class.

Closes #410
jrconlin added a commit that referenced this issue Mar 16, 2016
@jrconlin
bug: decode and process crypto-key header correctly
f5c012b 
The Crypto-Key header has a different format than what was first
understood. A valid Crypto-Key header may look like `keyid="foo";
key1="data",key2="data"`. This patch specialized Crypto-Key parsing
to a class.

Closes #410
@jrconlin jrconlin mentioned this issue Mar 16, 2016
Merged
jrconlin added a commit that referenced this issue Mar 17, 2016
@jrconlin
bug: decode and process crypto-key header correctly
9743e29 
The Crypto-Key header has a different format than what was first
understood. A valid Crypto-Key header may look like `keyid="foo";
key1="data",key2="data"`. This patch specialized Crypto-Key parsing
to a class.

Closes #410
jrconlin added a commit that referenced this issue Mar 17, 2016
@jrconlin
bug: decode and process crypto-key header correctly
a0a617e 
The Crypto-Key header has a different format than what was first
understood. A valid Crypto-Key header may look like `keyid="foo";
key1="data",key2="data"`. This patch specialized Crypto-Key parsing
to a class.

Closes #410
jrconlin added a commit that referenced this issue Mar 17, 2016
@jrconlin
bug: decode and process crypto-key header correctly
3ca48a7 
The Crypto-Key header has a different format than what was first
understood. A valid Crypto-Key header may look like `keyid="foo";
key1="data",key2="data"`. This patch specialized Crypto-Key parsing
to a class.

Closes #410
jrconlin added a commit that referenced this issue Mar 17, 2016
@jrconlin
bug: decode and process crypto-key header correctly
f546ed7 
The Crypto-Key header has a different format than what was first
understood. A valid Crypto-Key header may look like `keyid="foo";
key1="data",key2="data"`. This patch specialized Crypto-Key parsing
to a class.

Closes #410
@marco-c marco-c mentioned this issue Mar 23, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrconlin jrconlin

Labels
None yet
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

No branches or pull requests
2 participants
@jrconlin @bbangert