Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Capture ValueError when client may leave #385

Closed
bbangert opened this issue Mar 4, 2016 · 0 comments
Closed

Capture ValueError when client may leave #385

bbangert opened this issue Mar 4, 2016 · 0 comments
Assignees
@jrconlin
Milestone
PUSHSVC-0: quality

Comments

@bbangert
Copy link
Member

bbangert commented Mar 4, 2016

Per https://sentry.prod.mozaws.net/operations/autopush-prod/group/235881/

An AttributeError is caught, but not the ValueError that can occur. The ValueError should be caught as well.
@bbangert bbangert added the ready label Mar 4, 2016
@bbangert bbangert added this to the PUSHSVC-0: quality milestone Mar 4, 2016
jrconlin added a commit that referenced this issue Mar 4, 2016
@jrconlin
bug: capture ValueError for empty notifications arrays
ce27f1e 
Empty pending notification arrays may be returned. Removing a value can
trigger a ValueError that can be safely ignored.

Closes #385
@jrconlin jrconlin mentioned this issue Mar 4, 2016
Merged
@jrconlin jrconlin self-assigned this Mar 4, 2016
@jrconlin jrconlin added in progress and removed ready labels Mar 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrconlin jrconlin

Labels
None yet
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

No branches or pull requests
2 participants
@jrconlin @bbangert