Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Support channel association with a JWT key #326

Closed
bbangert opened this issue Feb 2, 2016 · 3 comments
Closed

Support channel association with a JWT key #326

bbangert opened this issue Feb 2, 2016 · 3 comments
Assignees
@jrconlin
Labels
enhancement

Comments

@bbangert
Copy link
Member

bbangert commented Feb 2, 2016

Channel subscriptions will allow association with a sender key per:
w3c/push-api#182

Our register command will need updating to support the additional information, and our channel-id scheme of a list of channels may need modification to store an additional crypto key with it.

The endpoint will need an additional check to ensure the sender key validates with the channel key if present.

Depends on: #325
@bbangert
Copy link
Member Author

To ease storage requirements and schema changes, a sha256 of the public key should be stored in the endpoint itself. To facilitate this endpoint writing/reading scheme, the endpoint will need a prefix indicating the version of the endpoint encoding. No prefix indicates legacy endpoint generation.

Example:

endpoint_url/push/obscure([uaid.hex + ":" + chid.hex])
endpoint_url/push/v1/obscure([uaid.bytes + chid.bytes])
endpoint_url/push/v2/obscure([uaid.bytes + chid.bytes + sha256(public_key).bytes])

Where obscure() is the current method used to obscure data from casual discovery.

The appropriate endpoint verifier is then run for each version.

@jrconlin jrconlin mentioned this issue Feb 12, 2016
Closed
@jrconlin jrconlin self-assigned this Feb 12, 2016
jrconlin added a commit that referenced this issue Feb 29, 2016
@jrconlin
feature: Add channel association with JWT public key
6637b6b 
Fixes #326
jrconlin added a commit that referenced this issue Feb 29, 2016
@jrconlin
feature: allow channels to register with public key
af8132b 
Channels can include a public key when registering a new subscription
channel. This public key should match the public key used to send
subscription updates later.

NOTE: this patch changes the format of the endpoint URLs, & the content of
the endpoint URL token. This change also requires that ChannelIDs be
normalized to dashed format, (e.g. a lower case, dash delimited string
"deadbeef-0000-0000-deca-fbad11112222") This is the default mechanism
used by Firefox for UUID generation. It is STRONGLY urged that clients
normalize UUIDs used for ChannelIDs and User Agent IDs. While this
should not break existing clients, additional testing may be required.

Closes: #326
jrconlin added a commit that referenced this issue Feb 29, 2016
@jrconlin
feature: allow channels to register with public key
cf00be8 
Channels can include a public key when registering a new subscription
channel. This public key should match the public key used to send
subscription updates later.

NOTE: this patch changes the format of the endpoint URLs, & the content
of the endpoint URL token. This change also requires that ChannelIDs be
normalized to dashed format, (e.g. a lower case, dash delimited string
"deadbeef-0000-0000-deca-fbad11112222") This is the default mechanism
used by Firefox for UUID generation. It is STRONGLY urged that clients
normalize UUIDs used for ChannelIDs and User Agent IDs. While this
should not break existing clients, additional testing may be required.

Closes: #326
jrconlin added a commit that referenced this issue Feb 29, 2016
@jrconlin
feature: allow channels to register with public key
c75ca15 
Channels can include a public key when registering a new subscription
channel. This public key should match the public key used to send
subscription updates later.

NOTE: this patch changes the format of the endpoint URLs, & the content
of the endpoint URL token. This change also requires that ChannelIDs be
normalized to dashed format, (e.g. a lower case, dash delimited string
"deadbeef-0000-0000-deca-fbad11112222") This is the default mechanism
used by Firefox for UUID generation. It is STRONGLY urged that clients
normalize UUIDs used for ChannelIDs and User Agent IDs. While this
should not break existing clients, additional testing may be required.

Closes: #326
jrconlin added a commit that referenced this issue Feb 29, 2016
@jrconlin
feature: allow channels to register with public key
c40ea3e 
Channels can include a public key when registering a new subscription
channel. This public key should match the public key used to send
subscription updates later.

NOTE: this patch changes the format of the endpoint URLs, & the content
of the endpoint URL token. This change also requires that ChannelIDs be
normalized to dashed format, (e.g. a lower case, dash delimited string
"deadbeef-0000-0000-deca-fbad11112222") This is the default mechanism
used by Firefox for UUID generation. It is STRONGLY urged that clients
normalize UUIDs used for ChannelIDs and User Agent IDs. While this
should not break existing clients, additional testing may be required.

Closes: #326
@ghost
Copy link

ghost commented Feb 29, 2016

@jrconlin I'll send the subscription key as a Base64-encoded URL string, in the key field of the register message. Sound good?

jrconlin added a commit that referenced this issue Feb 29, 2016
@jrconlin
feature: allow channels to register with public key
d4f0c31 
Channels can include a public key when registering a new subscription
channel. This public key should match the public key used to send
subscription updates later.

NOTE: this patch changes the format of the endpoint URLs, & the content
of the endpoint URL token. This change also requires that ChannelIDs be
normalized to dashed format, (e.g. a lower case, dash delimited string
"deadbeef-0000-0000-deca-fbad11112222") This is the default mechanism
used by Firefox for UUID generation. It is STRONGLY urged that clients
normalize UUIDs used for ChannelIDs and User Agent IDs. While this
should not break existing clients, additional testing may be required.

Closes: #326
@jrconlin jrconlin mentioned this issue Feb 29, 2016
Merged
@jrconlin
Copy link
Member

jrconlin commented Mar 1, 2016

@kitcambridge yep, sounds good to me.

jrconlin added a commit that referenced this issue Mar 2, 2016
@jrconlin
feature: allow channels to register with public key
c269640 
Channels can include a public key when registering a new subscription
channel. This public key should match the public key used to send
subscription updates later.

NOTE: this patch changes the format of the endpoint URLs, & the content
of the endpoint URL token. This change also requires that ChannelIDs be
normalized to dashed format, (e.g. a lower case, dash delimited string
"deadbeef-0000-0000-deca-fbad11112222") This is the default mechanism
used by Firefox for UUID generation. It is STRONGLY urged that clients
normalize UUIDs used for ChannelIDs and User Agent IDs. While this
should not break existing clients, additional testing may be required.

Closes: #326
@bbangert bbangert removed the ready label Mar 2, 2016
jrconlin added a commit that referenced this issue Mar 2, 2016
@jrconlin
feature: allow channels to register with public key
5b01183 
Channels can include a public key when registering a new subscription
channel. This public key should match the public key used to send
subscription updates later.

NOTE: this patch changes the format of the endpoint URLs, & the content
of the endpoint URL token. This change also requires that ChannelIDs be
normalized to dashed format, (e.g. a lower case, dash delimited string
"deadbeef-0000-0000-deca-fbad11112222") This is the default mechanism
used by Firefox for UUID generation. It is STRONGLY urged that clients
normalize UUIDs used for ChannelIDs and User Agent IDs. While this
should not break existing clients, additional testing may be required.

Closes #326
jrconlin added a commit that referenced this issue Mar 2, 2016
@jrconlin
feature: allow channels to register with public key
f7bb8ef 
Channels can include a public key when registering a new subscription
channel. This public key should match the public key used to send
subscription updates later.

NOTE: this patch changes the format of the endpoint URLs, & the content
of the endpoint URL token. This change also requires that ChannelIDs be
normalized to dashed format, (e.g. a lower case, dash delimited string
"deadbeef-0000-0000-deca-fbad11112222") This is the default mechanism
used by Firefox for UUID generation. It is STRONGLY urged that clients
normalize UUIDs used for ChannelIDs and User Agent IDs. While this
should not break existing clients, additional testing may be required.

Closes #326
jrconlin added a commit that referenced this issue Mar 3, 2016
@jrconlin
feature: allow channels to register with public key
61af580 
Channels can include a public key when registering a new subscription
channel. This public key should match the public key used to send
subscription updates later.

NOTE: this patch changes the format of the endpoint URLs, & the content
of the endpoint URL token. This change also requires that ChannelIDs be
normalized to dashed format, (e.g. a lower case, dash delimited string
"deadbeef-0000-0000-deca-fbad11112222") This is the default mechanism
used by Firefox for UUID generation. It is STRONGLY urged that clients
normalize UUIDs used for ChannelIDs and User Agent IDs. While this
should not break existing clients, additional testing may be required.

Closes #326
jrconlin added a commit that referenced this issue Mar 3, 2016
@jrconlin
feature: allow channels to register with public key
baf7e67 
Channels can include a public key when registering a new subscription
channel. This public key should match the public key used to send
subscription updates later.

NOTE: this patch changes the format of the endpoint URLs, & the content
of the endpoint URL token. This change also requires that ChannelIDs be
normalized to dashed format, (e.g. a lower case, dash delimited string
"deadbeef-0000-0000-deca-fbad11112222") This is the default mechanism
used by Firefox for UUID generation. It is STRONGLY urged that clients
normalize UUIDs used for ChannelIDs and User Agent IDs. While this
should not break existing clients, additional testing may be required.

Closes #326
jrconlin added a commit that referenced this issue Mar 3, 2016
@jrconlin
feature: allow channels to register with public key
3d15b9b 
Channels can include a public key when registering a new subscription
channel. This public key should match the public key used to send
subscription updates later.

NOTE: this patch changes the format of the endpoint URLs, & the content
of the endpoint URL token. This change also requires that ChannelIDs be
normalized to dashed format, (e.g. a lower case, dash delimited string
"deadbeef-0000-0000-deca-fbad11112222") This is the default mechanism
used by Firefox for UUID generation. It is STRONGLY urged that clients
normalize UUIDs used for ChannelIDs and User Agent IDs. While this
should not break existing clients, additional testing may be required.

Closes #326
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrconlin jrconlin

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrconlin @bbangert