Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

save_channels uses a conditional check #320

Closed
bbangert opened this issue Feb 1, 2016 · 0 comments · Fixed by #322
Closed

save_channels uses a conditional check #320

bbangert opened this issue Feb 1, 2016 · 0 comments · Fixed by #322
Assignees
@bbangert
Labels
bug
Milestone
PUSHSVC-0: quality

Comments

@bbangert
Copy link
Member

bbangert commented Feb 1, 2016

Apparently using put_item in boto causes a conditional check to exist on the update. It's rather important that the channels are just saved out, otherwise the rest of the router table update won't proceed, and the transport won't resume.

The put_item should be replaced with a direct table update like our other functions to ensure the channels are correctly saved. An errback should be added to the table rotation that disconnects users that rotation fails for, since the pauseProducing means we will be unable to do anything with the user until they reconnect.
@bbangert bbangert added the bug label Feb 1, 2016
@bbangert bbangert added this to the PUSHSVC-0: quality milestone Feb 1, 2016
@bbangert bbangert self-assigned this Feb 1, 2016
bbangert added a commit that referenced this issue Feb 1, 2016
@bbangert
bug: overwrite records during monthly migration to avoid disconnect e…
5fda1e4 
…dge-case

During monthly rotation, if a user drops the connection after the monthly
rotation has begun, but before it completed, then the message table will be
updated but not the router table. This means that the next call will fail
since put_item wasn't called with overwrite=True. This patch fixes that
and includes an integration test to verify the fix.

Closes #320
@bbangert bbangert mentioned this issue Feb 1, 2016
Merged
pjenvey added a commit that referenced this issue Jun 28, 2017
@pjenvey
fix: add memory pressure for jwt's cryptography usage
bd6e32f 
related to cffi issue #320: pypy's GC isn't aware of many of
cryptography's allocations, manually add pressure for now so it keeps
up

Closes #917
pjenvey added a commit that referenced this issue Jun 28, 2017
@pjenvey
fix: add memory pressure for jwt's cryptography usage
ebc4695 
related to cffi issue #320: pypy's GC isn't aware of many of
cryptography's allocations, manually add pressure for now so it keeps
up

Closes #917
@pjenvey pjenvey mentioned this issue Jun 28, 2017
Closed
pjenvey added a commit that referenced this issue Jun 28, 2017
@pjenvey
fix: add memory pressure for jwt's cryptography usage
6719a32 
related to cffi issue #320: pypy's GC isn't aware of many of
cryptography's allocations, manually add pressure for now so it keeps
up

Closes #917
pjenvey added a commit that referenced this issue Jun 28, 2017
@pjenvey
fix: add memory pressure for jwt's cryptography usage
4eb82ec 
related to cffi issue #320: pypy's GC isn't aware of many of
cryptography's allocations, manually add pressure for now so it keeps
up

temporarily toggleable so we can experiment w/ it vs the cryptography
recent leak fix (cryptography PR 3732)

Closes #917
pjenvey added a commit that referenced this issue Jun 28, 2017
@pjenvey
fix: add memory pressure for jwt's cryptography usage
99048cd 
related to cffi issue #320: pypy's GC isn't aware of many of
cryptography's allocations, manually add pressure for now so it keeps
up

temporarily toggleable so we can experiment w/ it vs the cryptography
recent leak fix (cryptography PR 3732)

Closes #917
@pjenvey pjenvey mentioned this issue Jun 28, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbangert bbangert

Labels
bug
Projects
None yet
Milestone
PUSHSVC-0: quality
1 participant
@bbangert