Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Set UTF-8 decoding to "ignore"; resolve UnicodeDecodeError exceptions #180

Closed
jrconlin opened this issue Oct 12, 2015 · 5 comments
Closed

Set UTF-8 decoding to "ignore"; resolve UnicodeDecodeError exceptions #180

jrconlin opened this issue Oct 12, 2015 · 5 comments
Assignees
@bbangert
Labels
bug
Milestone
PUSHSVC-0: quality

Comments

@jrconlin
Copy link
Member

https://sentry.prod.mozaws.net/operations/autopush-prod/group/101610/

Enforcing strict UTF-8 decoding forces the connection to close. This may penalize users who are on buggy browsers. Instead we should set UTF-8 parsing to "ignore" and drop bad characters silently.

(If it's possible to log these types of events without impacting delivery to users, that would be useful.)
@bbangert bbangert added the bug label Oct 12, 2015
@bbangert
Copy link
Member

Should note, this actually isn't something we can fix directly, as its buried in autobahn code, so autobahn should fix it.

@bbangert bbangert added the ready label Oct 14, 2015
@bbangert bbangert self-assigned this Oct 19, 2015
@bbangert
Copy link
Member

Blocked on crossbario/autobahn-python#533.

@bbangert bbangert added this to the PUSHSVC-0: quality milestone Oct 21, 2015
@bbangert bbangert mentioned this issue Feb 18, 2016
Closed
bbangert added a commit that referenced this issue Feb 23, 2016
@bbangert
feat: upgrade autobahn/twisted to 0.12/15.5
47597a0 
Update the requirements to use the latest autobahn, and the recent
twisted/txaio/raven/eliot as well. Minor fixes to logging to ensure
the log output works with the new keys twisted 15.5 introduced.

Closes #351, #180
@bbangert bbangert mentioned this issue Feb 23, 2016
Merged
@bbangert
Copy link
Member

Closed by #364.

@bbangert bbangert added blocked and removed blocked labels Feb 23, 2016
@bbangert bbangert reopened this Feb 24, 2016
@bbangert
Copy link
Member

This has not actually been fixed in autobahn 0.12.1. Still waiting on a new release with it.

jrconlin pushed a commit that referenced this issue Feb 29, 2016
@bbangert @jrconlin
feat: upgrade autobahn/twisted to 0.12/15.5
4cadb77 
Update the requirements to use the latest autobahn, and the recent
twisted/txaio/raven/eliot as well. Minor fixes to logging to ensure
the log output works with the new keys twisted 15.5 introduced.

Closes #351, #180
@bbangert
Copy link
Member

0.13 finally fixed this.

@bbangert bbangert removed the blocked label Jun 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbangert bbangert

Labels
bug
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

No branches or pull requests
2 participants
@jrconlin @bbangert