Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix build.rs cbindgen handling of errors #1235

Closed
pjenvey opened this issue May 15, 2018 · 0 comments
Closed

fix build.rs cbindgen handling of errors #1235

pjenvey opened this issue May 15, 2018 · 0 comments
Assignees
@pjenvey
Labels
bug p1
Milestone
2018Q2-2.1 Rust c...

Comments

@pjenvey
Copy link
Member

pjenvey commented May 15, 2018

w/ cbindgen being ran before rustc, it should not panic during build failures: instead it should exit cleanly so rustc can run, showing the full reason for the error.

Maybe it should panic during release builds?
@pjenvey pjenvey added the bug label May 15, 2018
@pjenvey pjenvey self-assigned this May 15, 2018
@pjenvey pjenvey added the p1 label May 15, 2018
pjenvey added a commit that referenced this issue May 15, 2018
@pjenvey
fix: let the build continue to rustc on cbindgen failures
d2e4ef6 
silently remove autopush.h instead just in case cbindgen fails when rustc
doesn't (to indicate something went wrong)

Closes #1235
@pjenvey pjenvey mentioned this issue May 15, 2018
Merged
pjenvey added a commit that referenced this issue May 15, 2018
@pjenvey
fix: let the build continue to rustc on cbindgen failures
46f048a 
silently remove autopush.h instead just in case cbindgen fails when rustc
doesn't (to indicate something went wrong)

Closes #1235
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjenvey pjenvey

Labels
bug p1
Projects
None yet
Milestone
2018Q2-2.1 Rust connection node with ...
Development

No branches or pull requests
1 participant
@pjenvey