fix: return 404 for invalid URL's for consistency

URL's that are invalid should return a 404, just like any other invalid URL. Closes #578
mozilla-services · Aug 18, 2016 · bd7ba21 · bd7ba21
1 parent cf3f197
commit bd7ba21
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/autopush/tests/test_integration.py b/autopush/tests/test_integration.py
@@ -1318,7 +1318,7 @@ def test_with_key(self):
 
         yield client.send_notification(
             vapid=vapid,
-            status=400)
+            status=404)
 
         yield self.shut_down(client)
 

diff --git a/autopush/web/validation.py b/autopush/web/validation.py
@@ -199,7 +199,7 @@ def extract_subscription(self, d):
                 ckey_header=d["ckey_header"],
             )
         except (InvalidTokenException, InvalidToken):
-            raise InvalidRequest("invalid token", errno=102)
+            raise InvalidRequest("invalid token", status_code=404, errno=102)
         return result
 
     @validates_schema(skip_on_field_errors=True)