fix: log boolean values

Closes #915
mozilla-services · Jun 12, 2017 · 1ed34d5 · 1ed34d5
1 parent 56ab681
commit 1ed34d5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/autopush/logging.py b/autopush/logging.py
@@ -172,7 +172,7 @@ def to_fields(kv):
             reply = dict()
             for k, v in kv:
                 if (k not in IGNORED_KEYS and
-                        type(v) in (str, unicode, list, int, float)):
+                        type(v) in (str, unicode, list, int, float, bool)):
                     reply[k] = v
             return reply
 

diff --git a/autopush/tests/test_logging.py b/autopush/tests/test_logging.py
@@ -50,7 +50,7 @@ def test_sentry_logging(self):
         pl = PushLogger.setup_logging("Autopush", sentry_dsn=True)
         pl._output = out
         _client_info = dict(key='value')
-        _timings = dict(key2='value')
+        _timings = dict(key2='value', key3=True)
 
         log.failure(format="error",
                     failure=failure.Failure(Exception("eek")),
@@ -75,6 +75,7 @@ def check():
             payload = json.loads(out.readline())
             eq_(payload['Fields']['key'], 'value')
             eq_(payload['Fields']['key2'], 'value')
+            eq_(payload['Fields']['key3'], True)
             self._port.stopListening()
             pl.stop()
             d.callback(True)