fix: return correct not found for disconnected client and fix tests #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbangert
force-pushed
the
feat/issue-89
branch
from
4772d0d to
b4e918a
Compare
jrconlin
previously approved these changes
Jan 3, 2019
bbangert
force-pushed
the
feat/issue-89
branch
from
b4e918a to
e2c284d
Compare
pjenvey
requested changes
Jan 3, 2019
bbangert
force-pushed
the
feat/issue-89
branch
from
e2c284d to
4878387
Compare
pjenvey
previously approved these changes
Jan 3, 2019
bbangert
force-pushed
the
feat/issue-89
branch
from
4878387 to
87e2248
Compare
pjenvey
previously approved these changes
Jan 3, 2019
Tests weren't passing because autopush had a dependency change for FCM. This updates the travis test to pull down the current dependencies for autopush for integration tests. Closes #89
bbangert
force-pushed
the
feat/issue-89
branch
from
87e2248 to
5d6d29d
Compare
jrconlin
approved these changes
Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests weren't passing because autopush had a dependency change for FCM.
This updates the travis test to pull down the current dependencies for
autopush for integration tests.
Closes #89