chore(ci): Add capability to build and push test images to GCR. #812
Conversation
.circleci/config.yml
Outdated
| @@ -357,6 +340,7 @@ jobs: | |||
| default: build | |||
| image: | |||
| type: string | |||
| default: docker | |||
There was a problem hiding this comment.
This probably isn't necessary since we're not specifying a default for either of the build jobs and we're passing this parameter from every job that calls it.
There was a problem hiding this comment.
This looks good to me. If you want, you can test this out by having it temporarily filter against your branch instead of master in the job definitions. Once your push up a commit in your branch, CircleCI should try to build and deploy the images and I can confirm whether or not they were successfully pushed to GAR.
b4handjr
dismissed stale reviews from jrconlin and emaydeck-mozilla
via
e3c258b
b4handjr
force-pushed
the
sync-4559
branch
2 times, most recently
from
9d044e2 to
1a4956c
Compare
b4handjr
force-pushed
the
sync-4559
branch
2 times, most recently
from
af23d5a to
6c586fa
Compare
.circleci/config.yml
Outdated
| branches: | ||
| only: master |
There was a problem hiding this comment.
This is a departure from the way we have the PR builds setup currently. We usually build the load-test image in PR builds without deploying, so developers can be signaled before they merge if they have introduced a breaking change. I suggest to remove this filter and perhaps the one for the notification test container as well for the same reason.
When I was working on #812 I mislabeled the autoconnect/endpoint docker images in the deploy step. This should fix that. I am also running those steps on CI to make sure everything works.
Adds the steps needed to build and push our containerized tests to GCR.
SYNC-4559