Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move BT chunk processing into retry #806

Merged
merged 8 commits into from
Dec 16, 2024
Merged

feat: Move BT chunk processing into retry #806

merged 8 commits into from
Dec 16, 2024

Conversation

jrconlin
Copy link
Member

@jrconlin jrconlin commented Dec 3, 2024

Bigtable stream reads are not reliable, and may fail at any time.
Move the chunk processing into the retry section to reduce the number
of read errors that can happen.

Version and cargo update included because of an audit update.

Closes: SYNC-4508

Verified

This commit was signed with the committer’s verified signature.
jrconlin JR Conlin
Bigtable stream reads are not reliable, and may fail at any time.
Move the chunk processing into the retry section to reduce the number
of read errors that can happen.

Closes: SYNC-4508

Verified

This commit was signed with the committer’s verified signature.
jrconlin JR Conlin
*NOTE*
`cargo audit` may fail with an "Invalid version" if the `Cargo.lock`
version is set to 4. Manually changing to 3 will resolve this.
@jrconlin jrconlin requested review from pjenvey and taddes December 3, 2024 18:13
@jrconlin jrconlin changed the title feat: Move BT chuck processing into retry feat: Move BT chunck processing into retry Dec 4, 2024
@jrconlin jrconlin changed the title feat: Move BT chunck processing into retry feat: Move BT chunk processing into retry Dec 4, 2024

Verified

This commit was signed with the committer’s verified signature.
jrconlin JR Conlin
@jrconlin jrconlin requested a review from pjenvey December 11, 2024 20:41
jrconlin and others added 4 commits December 12, 2024 16:20

Verified

This commit was signed with the committer’s verified signature.
jrconlin JR Conlin
.

Verified

This commit was signed with the committer’s verified signature.
pjenvey Philip Jenvey
.

Verified

This commit was signed with the committer’s verified signature.
pjenvey Philip Jenvey
.

Verified

This commit was signed with the committer’s verified signature.
pjenvey Philip Jenvey
Comment on lines 521 to 522
error::BigTableError::GRPC(e)
| error::BigTableError::Read(e)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see these 2 variants being emitted in merge but I imagine you're guarding against them potentially happening in the future.

Being generic across BigTableError here convinced me we might as well clean all this up by making a retryable_bigtable_error version of retryable_error. How does this look?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, aside from the "InvalidRowResponse" it's behaving a lot like a generic GRPC error retry clause, but I don't think that it's worth the hassle of doing a stack call for just that. WFM.

Verified

This commit was signed with the committer’s verified signature.
jrconlin JR Conlin
@jrconlin jrconlin requested a review from pjenvey December 16, 2024 17:16
@jrconlin jrconlin merged commit 7edbcc7 into master Dec 16, 2024
1 check passed
@jrconlin jrconlin deleted the SYNC-4508_retry branch December 16, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants