refactor(integration): replace pytest.skip with pytest markers #798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing to use pytest markers instead of
pytest.skip + environment variables
for filtering integration tests. This will:As a workaround, I've added continued support for the environment variables in the Makefile.
Note: Tests that are filtered out are noted as 'deselected' in cmd output
Closes: #SYNC-4490
An alternative could be introducing a marker like
@pytest.mark.no_ci
. We could then leave thepytest.skip + environment variables
in place and still report skip rates accurately, but I find this less ideal because we would have multiple mechanisms for filtering tests. This complexity seems unnecessary.Add-on: I removed the
no-root
option in the Makefile because we use package-mode = false and should no longer need it according to this warning.