fix(circleci): now using correct project IDs, cleaned up env var names #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emaydeck-mozilla
requested review from
pjenvey,
jrconlin,
dlactin and
taddes
dlactin
approved these changes
Sep 4, 2024
pjenvey
pushed a commit
that referenced
this pull request
Sep 5, 2024
#762) I was accidentally using the GAR project ID for both OIDC and GAR. I updated this workflow to: - Use the correct values for each respective project ID - Rename the environment variables so their scopes are clearer (GAR vs OIDC) I already updated the corresponding environment variables on CircleCI.
emaydeck-mozilla
added a commit
that referenced
this pull request
Sep 5, 2024
#762) I was accidentally using the GAR project ID for both OIDC and GAR. I updated this workflow to: - Use the correct values for each respective project ID - Rename the environment variables so their scopes are clearer (GAR vs OIDC) I already updated the corresponding environment variables on CircleCI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was accidentally using the GAR project ID for both OIDC and GAR. I updated this workflow to:
I already updated the corresponding environment variables on CircleCI.