feat: add APNS timeouts for a2 #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrconlin
requested changes
Jul 25, 2024
autoendpoint/src/settings.rs
Outdated
| @@ -46,6 +46,12 @@ pub struct Settings { | |||
| pub fcm: FcmSettings, | |||
| pub apns: ApnsSettings, | |||
|
|
|||
| // These values correspond to the a2 library ClientConfig struct. | |||
There was a problem hiding this comment.
These settings are specific to APNS only. They should be placed in ApnsSettings.
There was a problem hiding this comment.
Np, I'll move them. The ticket had mentioned creating Autoendpoint settings and then passing those values to a2 during router configuration, so I put it in the autoendpoint settings. Does make more sense for them to be with apns, indeed!
…:ClientConfig and documented context
taddes
force-pushed
the
feat/SYNC-4302_add_apns_timeouts_a2_lib
branch
from
83ba6e4 to
22c3440
Compare
jrconlin
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per
ClientConfigstruct in a2 library, updated autoconnect Settings struct to holdrequest_timeout_secsandpool_idle_timeout_secs, definedefault()struct to pass intoClientConfig, with defaults set to what are the current defaults in a2. We can of course change them going forward. This way the settings are untethered from whatever a2 may change them to.Some contextual comments are included for clarity.
Closes SYNC-4307