-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to track messages based on known VAPID keys #739
Merged
+160
−7
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
5c160cb
feat: Add ability to track messages based on known VAPID keys
jrconlin 55788ee
Merge branch 'master' of github.com:mozilla-services/autopush-rs into…
jrconlin 67ab0cf
f add unit test
jrconlin 5fc4786
Merge branch 'master' into feat/SYNC-4349_track
jrconlin 1b71e07
Merge branch 'master' into feat/SYNC-4349_track
jrconlin e356cb0
f switch from bool to string
jrconlin e6ac463
Merge branch 'feat/SYNC-4349_track' of github.com:mozilla-services/au…
jrconlin 1f7ed3c
Merge branch 'master' into feat/SYNC-4349_track
jrconlin fa09789
Merge branch 'master' into feat/SYNC-4349_track
jrconlin 0f8c029
Merge branch 'master' into feat/SYNC-4349_track
jrconlin 4b92db5
feat: Add ability to track messages based on known VAPID keys
jrconlin 5067dc6
f add unit test
jrconlin d7482d5
f switch from bool to string
jrconlin 51917fc
f r's
jrconlin a5913a8
Merge branch 'feat/SYNC-4349_track' of github.com:mozilla-services/au…
jrconlin 57ac9bc
f fix merge
jrconlin 2e5c219
f r's
jrconlin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
feat: Add ability to track messages based on known VAPID keys
Closes: SYNC-4349
commit 5c160cb8a3963578443f0d85c7eb4c18c744fc55
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this isn't an actual setting I think it should live in
AppState
instead. Thenfn tracking_keys
won't need to do caching.(the existing
fn auth_keys
should probably similarly live inAppState
too instead of it reparsing the setting every time but I don't think it's that heavily called).It'll make it more annoying to test -- but can we just wrap it in a quick tuple struct with an
is_trackable
method to avoid needing anAppState
for the test?