feat: add implicit updates of channel records to update_user #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to refresh TTLs of all the router row data, allowing automatic garbage collection of inactive router records by Bigtable Closes SYNC-4221
…es in release builds)
pjenvey
force-pushed
the
feat/implicit-channel-refresh-SYNC-4221
branch
from
13c2e12 to
fba5073
Compare
jrconlin
reviewed
Jul 19, 2024
| connected_at: ms_since_epoch() - (10 * 60 * 1000), | ||
| ..Default::default() | ||
| })) | ||
| let user = User::builder() |
There was a problem hiding this comment.
Sad that we can't call ..Default::default() because the _channels item isn't technically writable, but very happy to have a builder method instead.
| @@ -201,6 +202,46 @@ fn to_string(value: Vec<u8>, name: &str) -> Result<String, DbError> { | |||
| }) | |||
| } | |||
|
|
|||
| /// Parse the "set" (see [DbClient::add_channels]) of channel ids in a bigtable Row. | |||
There was a problem hiding this comment.
+1 on extracting these into functions. Thanks!
pjenvey
force-pushed
the
feat/implicit-channel-refresh-SYNC-4221
branch
from
6d10d2c to
438a35f
Compare
taddes
approved these changes
Jul 22, 2024
| fn channels_to_cells(channels: Cow<HashSet<Uuid>>, expiry: SystemTime) -> Vec<cell::Cell> { | ||
| let channels = channels.into_owned(); | ||
| let mut cells = Vec::with_capacity(channels.len().min(100_000)); | ||
| for (i, channel_id) in channels.into_iter().enumerate() { |
There was a problem hiding this comment.
Is there a desire to check the size of challens prior to iteration, or is it intended to be a processing limit at runtime while looping through? Just curious in case a check before iterating was valuable.
There was a problem hiding this comment.
Yes, we're going to begin enforcing a max limit of channels shortly, which will probably end up changing this check #733
jrconlin
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to refresh TTLs of all the router row data, allowing automatic garbage collection of inactive router records by Bigtable
Closes SYNC-4221
So this isn't too much code and doesn't appear to be generally all that annoying (yet), shall we go with this route? It saves us a couple extra db calls -- as we are already reading (at least requesting from bigtable) all channels in
get_user.