feat: emit pool timeouts/conditional failures as metrics (not sentry) #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and refactor BigtableClientManager::Error to use BigTableError Closes: SYNC-4190
pjenvey
force-pushed
the
feat/pool-timeout-metrics-SYNC-4190
branch
from
ac03408 to
9ef2ecf
Compare
pjenvey
commented
Apr 5, 2024
| @@ -108,8 +108,6 @@ pub enum ApcErrorKind { | |||
| ParseUrlError(#[from] url::ParseError), | |||
| #[error(transparent)] | |||
| ConfigError(#[from] config::ConfigError), | |||
| #[error(transparent)] | |||
| DbError(#[from] crate::db::error::DbError), | |||
There was a problem hiding this comment.
ApcError's gonna get significant cleanup when we kill the autopush crate, so since this was only used in one place I just killed it
jrconlin
previously approved these changes
Apr 5, 2024
jrconlin
approved these changes
Apr 5, 2024
| @@ -51,7 +51,9 @@ impl AppState { | |||
| let fernets: Vec<Fernet> = crypto_key | |||
| .split(',') | |||
| .map(|s| s.trim().to_string()) | |||
| .map(|key| Fernet::new(&key)._or_else(|| panic!("Invalid {ENV_PREFIX}_CRYPTO_KEY"))) | |||
| .map(|key| { | |||
| Fernet::new(&key).unwrap_or_else(|| panic!("Invalid {ENV_PREFIX}_CRYPTO_KEY")) | |||
There was a problem hiding this comment.
Huh, not sure why that didn't get flagged by the analyzer when I loaded you branch.
Goes and tries to figure out what's broken
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and refactor BigtableClientManager::Error to use BigTableError
Closes: SYNC-4190