Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add initial async features for client #653

Merged
merged 12 commits into from
Mar 20, 2024
Merged

refactor: add initial async features for client #653

merged 12 commits into from
Mar 20, 2024

Conversation

taddes
Copy link
Contributor

@taddes taddes commented Mar 8, 2024 •
edited by jira bot
Loading

Closes: SYNC-4119

@taddes taddes self-assigned this Mar 8, 2024
@taddes taddes changed the title WIP: refactor: add initial async features for refactor refactor: add initial async features for client Mar 9, 2024
@taddes taddes requested a review from pjenvey March 9, 2024 02:47
@taddes taddes marked this pull request as ready for review March 9, 2024 02:47
@taddes taddes force-pushed the refactor/SYNC-4119_asyncio_client_httpx_websockets branch from 1ef30b0 to 474cba3 Compare March 9, 2024 03:31
@taddes
Copy link
Contributor Author

taddes commented Mar 12, 2024

@pjenvey Updated to use an earlier variant of a timeout method asyncio provides, since the async context manager isn't added till 3.11. When we upgrade python we can make use of that

asyncio.timeout-docs

asyncio.wait_for-docs

@taddes taddes force-pushed the refactor/SYNC-4119_asyncio_client_httpx_websockets branch 2 times, most recently from 93f6ede to 144ba08 Compare March 15, 2024 22:20
@taddes taddes requested a review from jrconlin March 19, 2024 20:29
@taddes taddes force-pushed the refactor/SYNC-4119_asyncio_client_httpx_websockets branch from 0a45306 to cb8cb99 Compare March 20, 2024 12:33
@taddes taddes requested a review from jrconlin March 20, 2024 12:33
taddes added 12 commits March 20, 2024 11:46
@taddes
add httpx, websockets, pytest-asyncio dependencies
97c3755
@taddes
replace requests with httpx, trailing space error in auth token for t…
89b6110 
…est_basic_delivery_with_invalid_vapid_auth, Illegal header value 'Bearer '
@taddes
refactor send_message
caa3aa0
@taddes
update test suite to use httpx and httpx exceptions
d8ba706
@taddes
implement async context managers for httpx requests
685a242
@taddes
update methods to use websocketsWebSocketClientProtocol and async await
33ceaf6
@taddes
asyncio.timeout context managers
153747c
@taddes
docstrings for clearer documentation of client logic for sending
b8c7a4c
@taddes
TestRustWebPushBroadcast refactored to use asyncio, pytest-asyncio an…
3310860 
…d await calls from Async push test client
@taddes
changing to asyncio.wait_for since feature added in 3.11, don't yet h…
338ed1e 
…ave support for
@taddes
fix poetry lock file for CI
94f92c8
@taddes
review comment remove assertion for - in uaid
2a22bc0
@taddes taddes force-pushed the refactor/SYNC-4119_asyncio_client_httpx_websockets branch from cb8cb99 to 2a22bc0 Compare March 20, 2024 15:47
@taddes taddes merged commit 22f058e into master Mar 20, 2024
1 check passed
@taddes taddes deleted the refactor/SYNC-4119_asyncio_client_httpx_websockets branch March 20, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrconlin jrconlin jrconlin approved these changes

@pjenvey pjenvey Awaiting requested review from pjenvey

Assignees

@taddes taddes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taddes @jrconlin