Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade sentry to 0.8.0 and log out errors #65

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Conversation

bbangert
Copy link
Member

Previously we only logged panics to sentry, this commit add's logging
of all errors except several ignored classifications.

Closes #5

Previously we only logged panics to sentry, this commit add's logging
of all errors except several ignored classifications.

Closes #5
@bbangert
Copy link
Member Author

The test had to be skipped, because the local HTTP server is not getting the data for some reason. However when running it and having an nc server get it, it does work. I've dug into the HTTP server Python sets up and added more debugging, but nothing seems to come in for unknown reasons.

I'd like to see if this works on dev/stage so we can proceed with a release tag tomorrow, and then spend however much time is needed to determine why the local Python HTTP server is not getting the request when the data seems to be sent in a full test environment.

@pjenvey pjenvey merged commit 2435c7f into master Aug 30, 2018
@pjenvey pjenvey deleted the feat/issue-5 branch August 30, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants