feat: have Bigtable match DynamoDB's metrics #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
commented
Feb 20, 2024
| @@ -128,10 +134,6 @@ impl DualClientImpl { | |||
| } else { | |||
| (Box::new(&self.primary), true) | |||
| }; | |||
| self.metrics | |||
There was a problem hiding this comment.
This was using the wrong metric label but it seemed too chatty to emit it for every single allot call, so I've moved this to emit its configured median only once at startup.
I think the combination of the added metrics/tags in this PR and the db's own metrics should give us a sense of what allot is doing anyway.
(not including conversion errors which never occur) Closes: SYNC-4150
pjenvey
force-pushed
the
feat/generic-db-metrics-SYNC-4150
branch
from
85c4cd2 to
4c299ae
Compare
jrconlin
previously approved these changes
Feb 20, 2024
jrconlin
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(not including conversion errors which never occur)
Closes: SYNC-4150