feat: simplify StoredNotifAutopushUser's on_start #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to match AutopushUser's quicker initializion time when locust is spawning and setup a quick matching shape class Issue: SYNC-3916
pjenvey
commented
Feb 14, 2024
| @@ -85,3 +86,11 @@ def tick(self) -> TickTuple | None: | |||
| spawn_rate: float = max(abs(users - self.get_current_user_count()), 1) | |||
|
|
|||
| return users, spawn_rate, self.user_classes | |||
|
|
|||
|
|
|||
| class StoredNotifAutopushLoadTestShape(AutopushLoadTestShape): | |||
There was a problem hiding this comment.
Adding StoredNotifAutopushUser to AutopushLoadTestShape seemed to force both classes usage during the load test. So I setup this subclass for now so we can focus on solely StoredNotifAutopushUser, we can revisit this later.
b4handjr
reviewed
Feb 14, 2024
jrconlin
reviewed
Feb 14, 2024
jrconlin
previously approved these changes
Feb 14, 2024
jrconlin
approved these changes
Feb 14, 2024
b4handjr
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to match AutopushUser's quicker initializion time when locust is spawning
and setup a quick matching shape class
Issue: SYNC-3916