-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a new test that produces stored notifs #598
Conversation
(a quick, initial implementation) this uses the more basic websocket.WebSocket as WebSocketApp.run_forever doesn't seem to handle the workflow needed (where the websocket is kept disconnected for a large portion of the test) Issue: SYNC-3916
What's changed between this and locustfile.py: |
57616b7
to
e45901e
Compare
|
||
Message: TypeAlias = HelloMessage | NotificationMessage | RegisterMessage | UnregisterMessage | ||
Record: TypeAlias = HelloRecord | NotificationRecord | RegisterRecord | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to include the enableTrace
and setdefaulttimeout
that were defined in locustfile.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope because it's global it should only be done in one place, especially since we invoke locust on both locustfile/stored.py
. Those lines should probably move out of locustfile.py
into a shared module eventually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you wanting to update the load.py Shape to include a percentage of this type of user? Or maybe this is a follow-up?
Also I'm curious if the on_ws
lifecycle methods are working?
Aaand looks like black became more pedantic about the comment strings. |
Let's make this a followup, we'll probably initially start with solely using
Only |
(a quick, initial implementation)
this uses the more basic websocket.WebSocket as WebSocketApp.run_forever
doesn't seem to handle the workflow needed (where the websocket is kept
disconnected for a large portion of the test)
Issue: SYNC-3916