feat: Add integration test for dual mode
#582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrconlin
commented
Jan 29, 2024
| @@ -69,8 +69,8 @@ | |||
| MP_CONNECTION_PORT = 9052 | |||
| MP_ROUTER_PORT = 9072 | |||
|
|
|||
| CONNECTION_BINARY = os.environ.get("CONNECTION_BINARY", "autopush_rs") | |||
| CONNECTION_SETTINGS_PREFIX = os.environ.get("CONNECTION_SETTINGS_PREFIX", "autopush__") | |||
| CONNECTION_BINARY = os.environ.get("CONNECTION_BINARY", "autoconnect") | |||
There was a problem hiding this comment.
since we no longer use autopush_rs, switching to autoconnect for this.
There was a problem hiding this comment.
Can you kill the CONNECTION_BINARY/SETTINGS override in the Makefile's integration-test target along with this?
pjenvey
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an integration test for "Dual" mode. Note that this uses a database settings file
dual_test.jsonto contain the doubly escaped values. The values in this file should match those used intest_integration_all_rust.pyfor data store configuration and set-up.This also adds a bit more
debugmessages to indicate successful operations. This was useful while determining a few problems with the configuration, but are not strongly required. I can remove them if requested.Closes: https://mozilla-hub.atlassian.net/browse/SYNC-4111