feat: don't store duplicated message columns #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
force-pushed
the
feat/bigtable-schema-cleanup2-SYNC-4070
branch
from
74ba4f6 to
e141505
Compare
- channel_id/topic/sortkey_timestamp (in the row key) - expiry (in the cell timestamps) (we can always add these back to messages later if they are worth having) - make add_user conditional, erroring out if the user already exists - utilize row_limit in message reads - enforce non null columns on deserialization Closes: SYNC-4070 Closes: SYNC-4099 Closes: SYNC-4106
pjenvey
force-pushed
the
feat/bigtable-schema-cleanup2-SYNC-4070
branch
from
e141505 to
b581438
Compare
jrconlin
approved these changes
Jan 29, 2024
jrconlin
pushed a commit
that referenced
this pull request
Jan 29, 2024
- channel_id/topic/sortkey_timestamp (in the row key) - expiry (in the cell timestamps) (we can always add these back to messages later if they are worth having) - make add_user conditional, erroring out if the user already exists - utilize row_limit in message reads - enforce non null columns on deserialization Closes: SYNC-4070 Closes: SYNC-4099 Closes: SYNC-4106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(we can always add these back to messages later if they are worth having)
Closes: SYNC-4070
Closes: SYNC-4099
Closes: SYNC-4106