Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stop building legacy autopush #575

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

pjenvey
Copy link
Member

@pjenvey pjenvey commented Jan 25, 2024

as its pending removal

Issue: SYNC-4036

I don't want to finish the rest of SYNC-4036 at this moment but this first step will save build time (mostly for local builds)

as its pending removal

Issue: SYNC-4036
@pjenvey pjenvey requested a review from jrconlin January 25, 2024 17:09
jrconlin
jrconlin previously approved these changes Jan 26, 2024
@@ -326,14 +326,14 @@ workflows:
filters:
tags:
only: /.*/
- build:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you'd yell at me that these should be deleted, not commented.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't bother since we're probably killing the rest of this shortly but fair enough

@jrconlin jrconlin merged commit 8026449 into master Jan 26, 2024
1 check passed
@jrconlin jrconlin deleted the chore/skip-legacy-autopush-SYNC-4036 branch January 26, 2024 17:14
jrconlin added a commit that referenced this pull request Jan 29, 2024
as its pending removal

Issue: SYNC-4036

I don't want to finish the rest of SYNC-4036 at this moment but this
first step will save build time (mostly for local builds)

---------

Co-authored-by: JR Conlin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants