bug: copy over the channels when migrating the user #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will attempt to copy the existing channels for a user. This is important because desktop does not check and rebuild channels if the server doesn't have them. (Might want to make that a standardized feature in the future.) Closes: SYNC-4050
pjenvey
reviewed
Dec 19, 2023
| .conn | ||
| .mutate_rows(&req) | ||
| .map_err(error::BigTableError::Write)?; | ||
| // TODO: is there a better way to do this? I don't think we care about the return stream. |
There was a problem hiding this comment.
A problem is that it's a stream of results of each individual mutation. It appears some in the batch can succeed while others fail. I think at the very least we need to loop through the stream to check every result: this currently only checks the first result.
…autopush-rs into bug/sync-4050_channels
pjenvey
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will attempt to copy the existing channels for a user. This is important because desktop does not check and rebuild channels if the server doesn't have them. (Might want to make that a standardized feature in the future.)
Closes: SYNC-4050