feat: Add metrics for user creation/deletion. #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a few questions raised about possible UAID churn occuring with autoconnect. Adding some metrics Add new metrics for: * `ua.expiration` - a UAID has been reset for * `reason`:(`reset_uaid`|`too_many_messages`|`no_current_mo`|`invalid_current_mo`) * added `autoconnect`:`true` for consistency * `ua.existing_user` - A user was found in the database * `ua.new_user` - no record was found, assinging a new UAID. * `reassined`: Was a UAID offered by the UA? Closes: SYNC-3994
pjenvey
requested changes
Nov 3, 2023
autoconnect/autoconnect-ws/autoconnect-ws-sm/src/identified/mod.rs
Outdated
Show resolved
Hide resolved
autoconnect/autoconnect-ws/autoconnect-ws-sm/src/unidentified.rs
Outdated
Show resolved
Hide resolved
pjenvey
requested changes
Nov 3, 2023
autoconnect/autoconnect-ws/autoconnect-ws-sm/src/identified/mod.rs
Outdated
Show resolved
Hide resolved
autoconnect/autoconnect-ws/autoconnect-ws-sm/src/unidentified.rs
Outdated
Show resolved
Hide resolved
autoconnect/autoconnect-ws/autoconnect-ws-sm/src/unidentified.rs
Outdated
Show resolved
Hide resolved
…d.rs Co-authored-by: Philip Jenvey <[email protected]>
…autopush-rs into feat/sync-3994-metrics
pjenvey
requested changes
Nov 6, 2023
autoconnect/autoconnect-ws/autoconnect-ws-sm/src/identified/on_client_msg.rs
Outdated
Show resolved
Hide resolved
autoconnect/autoconnect-ws/autoconnect-ws-sm/src/identified/on_server_notif.rs
Outdated
Show resolved
Hide resolved
autoconnect/autoconnect-ws/autoconnect-ws-sm/src/unidentified.rs
Outdated
Show resolved
Hide resolved
…autopush-rs into feat/sync-3994-metrics
This is more indicitive of what the flag is for and what it does.
pjenvey
requested changes
Nov 8, 2023
pjenvey
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few questions raised about possible UAID churn occuring with autoconnect. Adding some metrics
Add new metrics for:
ua.expiration- a UAID has been reset forreason:(reset_uaid|too_many_messages|no_current_mo|invalid_current_mo)autoconnect:truefor consistencyua.existing_user- A user was found in the databaseua.new_user- no record was found, assinging a new UAID.reassined: Was a UAID offered by the UA?Closes: SYNC-3994