Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle already connected users #495

Merged
merged 1 commit into from
Oct 31, 2023
Merged

feat: handle already connected users #495

merged 1 commit into from
Oct 31, 2023

Conversation

pjenvey
Copy link
Member

@pjenvey pjenvey commented Oct 31, 2023

@pjenvey pjenvey requested a review from jrconlin October 31, 2023 23:35
jrconlin
jrconlin approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@jrconlin jrconlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was debating about making the autoendpoint conditional errors more explicit but I think the traceback should suffice.

autopush-common/src/db/bigtable/bigtable_client/mod.rs
self.add_user(user).await
async fn update_user(&self, user: &User) -> DbResult<bool> {
self.add_user(user).await?;
// TODO: is a conditional check possible?
Copy link
Member

@jrconlin jrconlin Oct 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add this as a TODO:
Bigtable wants to overwrite, so we may need to do a pre-emptive read first. I can contain that to the add_user() function.

https://mozilla-hub.atlassian.net/browse/SYNC-3982

jrconlin
jrconlin approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@jrconlin jrconlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was debating about making the autoendpoint conditional errors more explicit but I think the traceback should suffice.

@pjenvey pjenvey merged commit eb53bec into master Oct 31, 2023
1 check passed
@pjenvey pjenvey deleted the feat/already-connected-SYNC-3980 branch October 31, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrconlin jrconlin jrconlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjenvey @jrconlin