feat: Run GCM through FCMv1 HTTP API #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
reviewed
Oct 2, 2023
pjenvey
requested changes
Oct 2, 2023
This runs GCM messages through the FCMv1 HTTP API (Using existing FCM
OAuth credentials, but GCM routing IDs.) This patch is part of an
emergency deploy to address 100% GCM failure rates.
Delivery errors for GCM WILL NOT DELETE the GCM route, but will record
a metric. This is to prevent potential loss.
It is recommended that this branch be deployed to a canary.
BREAKING CHANGE:
Please alter GCM credentials in `AUTOEND__FCM__CREDENTIALS`
These should use the same credential set as main FCM channel.
(e.g.
```
"0123456789" : { "project_id": "0123456789", "credential":"012ABC..."}
```
should become:
```
"0123456789": {"project_id": "0123456789", "is_gcm": true, "credential":"{\"type\":\"service_account\",\"project_id\":\"box...\"}"
```
)
Issue: Sync-3943
jrconlin
force-pushed
the
feat/SYNC-3943_gcm2fcm
branch
from
62ab285 to
628eade
Compare
pjenvey
approved these changes
Oct 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs GCM messages through the FCMv1 HTTP API (Using existing FCM OAuth credentials, but GCM routing IDs.) This patch is part of an emergency deploy to address 100% GCM failure rates.
Delivery errors for GCM WILL NOT DELETE the GCM route, but will record a metric. This is to prevent potential loss.
It is recommended that this branch be deployed to a canary.
BREAKING CHANGE:
Please alter GCM credentials in
AUTOEND__FCM__CREDENTIALSThese should use the same credential set as main FCM channel.
(e.g.
should become:
Issue: Sync-3943