Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: emit a tag in autoconnect's metrics #435

Merged
merged 2 commits into from
Sep 25, 2023
Merged

feat: emit a tag in autoconnect's metrics #435

merged 2 commits into from
Sep 25, 2023

Conversation

pjenvey
Copy link
Member

@pjenvey pjenvey commented Sep 5, 2023 •
edited by jira bot
Loading

to distinguish its metrics from the legacy version

and consolidate autoendpoint's metrics builder w/ autopush_common's

SYNC-3893

@pjenvey pjenvey requested a review from jrconlin September 5, 2023 22:51
@pjenvey
feat: emit a tag in autoconnect's metrics
1539604 
to distinguish its metrics from the legacy version

and consolidate autoendpoint's metrics builder w/ autopush_common's

SYNC-3893
@pjenvey pjenvey force-pushed the feat/autoconnect-metrics-tag-SYNC-3893 branch from 138b4b3 to 1539604 Compare September 5, 2023 22:53
jrconlin
jrconlin approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@jrconlin jrconlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit torn about having these both use the legacy mark. I can see having them on the same chart might be a bit easier to compare, but I think it might be hard to distinguish them cleanly.

@pjenvey pjenvey merged commit 6718685 into master Sep 25, 2023
1 check passed
@pjenvey pjenvey deleted the feat/autoconnect-metrics-tag-SYNC-3893 branch September 25, 2023 22:35
@jrconlin jrconlin mentioned this pull request Sep 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrconlin jrconlin jrconlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjenvey @jrconlin