feat: Topic messages shouldn't have sortkey_timestamps #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @jrconlin I put the naming change in a different branch against feat/big_table feat/big_table...feat/big_table-chid_msgid |
jrconlin
approved these changes
Jul 17, 2023
| } | ||
| false | ||
| }); | ||
| // TODO: A batch remove_messages would be nicer |
There was a problem hiding this comment.
technically, we should use the Topic Family to say that only one version of this should be stored or returned, but we can work on that later.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix autoconnect's db initialization to match autoendpoint's (don't panic when no DB_DSN is set)
don't unnecessarily remove expired messages in a background task during check storage
SYNC-3777
SYNC-3809