Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: further clean up #399

Merged
merged 14 commits into from
Oct 23, 2023
Merged

docs: further clean up #399

merged 14 commits into from
Oct 23, 2023

Conversation

jrconlin
Copy link
Member

  • fill out the FCM doc a bit more
  • add pointer to API docs
  • clean up running doc a bit

* fill out the FCM doc a bit more
* add pointer to API docs
* clean up `running` doc a bit
@jrconlin jrconlin requested a review from pjenvey July 13, 2023 22:18
docs/src/fcm.md Outdated Show resolved Hide resolved
@jrconlin jrconlin requested a review from pjenvey July 25, 2023 22:37
Copy link
Member

@pjenvey pjenvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just missed a merge conflict

Comment on lines 196 to 202
<<<<<<< HEAD
- add `fcm_enabled` to enable FCM routing.
- add `fcm_creds`. This is a json block with the following format:
=======
- add `fcm_enabled` to enable FCM routing.
- add `fcm_creds`. This is a json block with the following format:
>>>>>>> 483aa37012670fbaf9f52bd25a3abfc9f3ffdd6d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<<<<<<< HEAD
- add `fcm_enabled` to enable FCM routing.
- add `fcm_creds`. This is a json block with the following format:
=======
- add `fcm_enabled` to enable FCM routing.
- add `fcm_creds`. This is a json block with the following format:
>>>>>>> 483aa37012670fbaf9f52bd25a3abfc9f3ffdd6d
- add `fcm_enabled` to enable FCM routing.
- add `fcm_creds`. This is a json block with the following format:

Copy link
Member

@pjenvey pjenvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@jrconlin jrconlin requested a review from pjenvey October 16, 2023 15:24
@pjenvey pjenvey merged commit 61d784f into master Oct 23, 2023
1 check passed
@pjenvey pjenvey deleted the docs/deploy2 branch October 23, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants