fix: don't eat WebpushSocket poll_complete errors #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead check specifically for the harmless connection closed error and don't log it also remove the stacktrace from ApcError::to_string, include it in the sentry event exception instead Issue SYNC-3444
pjenvey
force-pushed
the
fix/SYNC-3444-poll_complete
branch
from
3e41b6e to
2df7642
Compare
jrconlin
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead check specifically for the harmless connection closed error and don't log it
also remove the stacktrace from ApcError::to_string, include it in the sentry event exception instead
Issue SYNC-3444