feat: Add additional metrics for message tracking [CONSVC-1660] #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `notification.message.expired` -- In flight message has no TTL, endpoint is unavailable. * `notification.message.stored` -- message stored for later transmission * `notification.message.retrieved` -- message extracted from storage * `ua.notification.sent` -- sent a notification to the websocket endpoint Issue: CONSVC-1660
pjenvey
requested changes
Oct 11, 2022
| metrics | ||
| .incr_with_tags("ua.notification.sent") | ||
| .with_tag("source", source) | ||
| .send(); |
There was a problem hiding this comment.
A thought: we could kill the ua.notification.topic above for a topic tag here like the other new metrics are doing
pjenvey
requested changes
Jan 14, 2023
pjenvey
reviewed
Jan 17, 2023
autopush/src/client.rs
Outdated
| @@ -600,36 +603,37 @@ where | |||
| } | |||
| let now = ms_since_epoch(); | |||
| let elapsed = (now - webpush.connected_at) / 1_000; | |||
| let (ua_result, metrics_os, metrics_browser) = parse_user_agent(&user_agent); | |||
| let ua_info = UserAgentInfo::from(user_agent.as_ref()); | |||
There was a problem hiding this comment.
Sorry one last thing, you shouldn't need to parse it again:
Suggested change
| let ua_info = UserAgentInfo::from(user_agent.as_ref()); | |
| let ua_info = webpush.ua_info.clone(); |
There was a problem hiding this comment.
Thanks! I realized that we don't need to pass the user_agent string anymore, so that's also been removed.
pjenvey
previously approved these changes
Jan 18, 2023
pjenvey
approved these changes
Jan 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notification.message.expired-- In flight message has no TTL, endpoint is unavailable.notification.message.stored-- message stored for later transmissionnotification.message.retrieved-- message extracted from storageua.notification.sent-- sent a notification to the websocket endpointIssue: CONSVC-1660