Bug/326 overflow #327
Merged
Bug/326 overflow #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* also apply 1.63 clippy fixex Closes: #326
jrconlin
commented
Aug 15, 2022
| @@ -335,6 +335,7 @@ mod tests { | |||
| const DEVICE_TOKEN: &str = "test-token"; | |||
| const APNS_ID: &str = "deadbeef-4f5e-4403-be8f-35d0251655f5"; | |||
|
|
|||
| #[allow(clippy::type_complexity)] | |||
| /// A mock APNS client which allows one to supply a custom APNS response/error | |||
| struct MockApnsClient { | |||
| send_fn: Box<dyn Fn(Payload<'_>) -> Result<a2::Response, a2::Error> + Send + Sync>, | |||
There was a problem hiding this comment.
We probably should make this a discrete type, but we only do this once, and I don't think it kills readability.
pjenvey
approved these changes
Aug 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.