Fxa fixes #321
Merged
Fxa fixes #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added more verbose `trace!` and `debug!` logging messages. * ignore padding errors for VAPID keys * bumped up default max bytes to handle base64 encoded 4096 block
We can't add the key to metrics (cardinality). We can log it locally and monitor a given server for a short period, though.
pjenvey
reviewed
Jul 13, 2022
| // The error (e.g. VapidErrorKind::InvalidKey(String)) might be too cardinal, | ||
| // but we may need that information to debug a production issue. We can | ||
| // add an info here, temporarily turn on info level debugging on a given server, | ||
| // capture it, and then turn it off before we run out of money. |
There was a problem hiding this comment.
We really need to just add extras support, logged: https://mozilla-hub.atlassian.net/browse/CONSVC-1886
pjenvey
approved these changes
Jul 13, 2022
| @@ -292,7 +306,8 @@ mod tests { | |||
| base64::STANDARD, | |||
| ) | |||
| .unwrap(); | |||
| let public_key = "BM3bVjW_wuZC54alIbqjTbaBNtthriVtdZlchOyOSdbVYeYQu2i5inJdft7jUWIAy4O9xHBbY196Gf-1odb8hds".to_owned(); | |||
| // Specify a potentially invalid padding. | |||
There was a problem hiding this comment.
Might be worth it to make this a separate test case
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.