bug: Fix GCM handling #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
requested changes
May 20, 2022
pjenvey
reviewed
May 21, 2022
pjenvey
requested changes
May 23, 2022
Closes: #308
We can't fix them, and they could overflow our quota. DEPLOY NOTE: Remove the sentry.io filter for "Bridge authentication error".
jrconlin
changed the title
pjenvey
previously approved these changes
May 24, 2022
ddurst
reviewed
May 24, 2022
| @@ -69,7 +69,7 @@ async fn validate_webpush_user( | |||
| } | |||
|
|
|||
| /// Drop a user and increment associated metric | |||
| async fn drop_user(uaid: Uuid, ddb: &dyn DbClient, metrics: &StatsdClient) -> ApiResult<()> { | |||
| pub async fn drop_user(uaid: Uuid, ddb: &dyn DbClient, metrics: &StatsdClient) -> ApiResult<()> { | |||
There was a problem hiding this comment.
Out of curiosity, why is pub added here?
There was a problem hiding this comment.
It was needed on an earlier version of this PR, the pub can be removed now (though it's not terribly important)
pjenvey
approved these changes
May 24, 2022
| @@ -69,7 +69,7 @@ async fn validate_webpush_user( | |||
| } | |||
|
|
|||
| /// Drop a user and increment associated metric | |||
| async fn drop_user(uaid: Uuid, ddb: &dyn DbClient, metrics: &StatsdClient) -> ApiResult<()> { | |||
| pub async fn drop_user(uaid: Uuid, ddb: &dyn DbClient, metrics: &StatsdClient) -> ApiResult<()> { | |||
There was a problem hiding this comment.
It was needed on an earlier version of this PR, the pub can be removed now (though it's not terribly important)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves GCM handling, using recently discovered docs of the discontinued protocol.
POST DEPLOY NOTE:
There is currently an ignore in place for
Bridge authentication errorthat will need to be removed.Closes: #308