chore: Update dependencies where possible. #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jrconlin
commented
Feb 3, 2021
jrconlin
commented
- Pinned dependencies contain comments indicating why they're pinned.
* Pinned dependencies contain comments indicating why they're pinned.
AzureMarker
reviewed
Feb 4, 2021
| @@ -13,15 +13,16 @@ edition = "2018" | |||
| # The `autoendpoint` branch merges these three PRs together. | |||
| # The version of a2 at the time of the fork is v0.5.3. | |||
| a2 = { git = "https://github.com/mozilla-services/a2.git", branch = "autoendpoint" } | |||
| actix-web = "3.2" | |||
| actix-rt = "1.1" | |||
| # several of these libraries are pinned due to https://github.com/mozilla-services/autopush-rs/issues/249 | |||
There was a problem hiding this comment.
Futures 0.3 is already used by autoendpoint, so these updates shouldn't necessarily be blocked:
Line 1411 in 365cb29
There was a problem hiding this comment.
From what i was seeing it's a compounding problem. Autoendpoint uses futures 0.3, but common doesn't always, and there are a bunch of changes rolled into the other dependencies that need to be made which we'd need to prioritize against what we've got upcoming.
Basically, "Yay! More tech debt due to wear out bits!".
Sigh.
pjenvey
requested changes
Feb 10, 2021
autoendpoint/Cargo.toml
Outdated
| actix-web = "3.2" | ||
| actix-rt = "1.1" | ||
| # several of these libraries are pinned due to https://github.com/mozilla-services/autopush-rs/issues/249 | ||
| actix-web = "3.2" # 3.3+ requires futures 0.3+ |
There was a problem hiding this comment.
3.3 is still on the older tokio/futures, autoendpoint's already using it according to Cargo.lock
pjenvey
approved these changes
Feb 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.