Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drop 0 TTL WebPush notifications if they aren't delivered the first time #210

Merged
merged 2 commits into from
Aug 6, 2020
Merged

fix: Drop 0 TTL WebPush notifications if they aren't delivered the first time #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a884df
Drop 0 TTL WebPush notifications if they aren't delivered the first time
AzureMarker Aug 5, 2020
be02619
Update tests
AzureMarker Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions autoendpoint/src/routers/webpush.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,14 @@ impl Router for WebPushRouter {
}
}

if notification.headers.ttl == 0 {
trace!(
"Notification has a TTL of zero and was not successfully \
delivered, dropping it"
);
return Ok(self.make_delivered_response(notification));
}

// Save notification, node is not present or busy
trace!("Node is not present or busy, storing notification");
self.store_notification(notification).await?;
Expand Down
2 changes: 1 addition & 1 deletion tests/test_integration_all_rust.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,7 @@ def test_ttl_0_not_connected(self):
data = str(uuid.uuid4())
client = yield self.quick_register()
yield client.disconnect()
yield client.send_notification(data=data, ttl=0)
yield client.send_notification(data=data, ttl=0, status=201)
yield client.connect()
yield client.hello()
result = yield client.get_notification(timeout=0.5)
Expand Down