Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validate user subscription data in autoendpoint #160

Merged
merged 6 commits into from
Jun 25, 2020

Conversation

AzureMarker
Copy link
Contributor

@AzureMarker AzureMarker commented Jun 22, 2020

User subscription data is now validated as part of the Actix extractor validations. Specifically:

  • Validate router type
  • (WebPush) Check that the subscription/channel exists
  • (WebPush) Drop user if inactive

This is the first autoendpoint feature to use the database, so support has been added. Part of those changes simplified DynamoStorage and made it Send + Sync.

Closes #156

jrconlin
jrconlin previously approved these changes Jun 22, 2020
autoendpoint/src/error.rs Show resolved Hide resolved
Base automatically changed from feat/autoendpoint-subscription-auth to master June 24, 2020 18:57
@pjenvey pjenvey dismissed jrconlin’s stale review June 24, 2020 18:57

The base branch was changed.

DynamoDbClient and StatsdClient both are internally Arc, so clones are
already cheap and refer to the same data. This change also makes
DynamoStorage Send + Sync.
The associated validation is not included, so it is unused.
@AzureMarker AzureMarker force-pushed the feat/autoendpoint-user-validations branch from dad74ae to a23e3be Compare June 24, 2020 20:37
@AzureMarker AzureMarker marked this pull request as ready for review June 24, 2020 20:37
@AzureMarker AzureMarker requested a review from jrconlin June 24, 2020 20:37
@AzureMarker AzureMarker merged commit 8efa42c into master Jun 25, 2020
@AzureMarker AzureMarker deleted the feat/autoendpoint-user-validations branch June 25, 2020 13:06
This was referenced Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[autoendpoint] Validate the user and subscription when handling incoming notifications
2 participants