Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry and don't report increment error #96

Closed
bbangert opened this issue Feb 7, 2019 · 1 comment
Closed

Retry and don't report increment error #96

bbangert opened this issue Feb 7, 2019 · 1 comment
Assignees
@bbangert
Labels
bug Something isn't working p1

Comments

@bbangert
Copy link
Member

bbangert commented Feb 7, 2019

The db/commands.rs was already updated to retry internal server errors, the db/mod should also have these updates, per Sentry:

InternalServerError

Internal server error

Msg

Error incrementing storage
@bbangert bbangert added bug Something isn't working p1 labels Feb 7, 2019
@bbangert
Copy link
Member Author

bbangert commented Feb 7, 2019

This also affects error deleting notification.

InternalServerError

Internal server error

Msg

Error deleting notification

@bbangert bbangert self-assigned this Feb 7, 2019
bbangert added a commit that referenced this issue Feb 7, 2019
@bbangert
feat: retry all dynamodb errors correctly, hide other invalid chid no…
dd06902 
…tice

Closes #96, #95
@bbangert bbangert mentioned this issue Feb 7, 2019
Merged
bbangert added a commit that referenced this issue Feb 7, 2019
@bbangert
feat: retry all dynamodb errors correctly, hide invalid chids
dbe152b 
Closes #96, #95
bbangert added a commit that referenced this issue Feb 7, 2019
@bbangert
feat: retry all dynamodb errors correctly, hide invalid chids
5815223 
Closes #96, #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbangert bbangert

Labels
bug Something isn't working p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bbangert