-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noncompliant Push Response #800
Comments
Could you be more specific about how this response is non-compliant? |
Thank you. We have identified a bug inside of our code where we return a 200 when messages are handed off to some routers. Since our system can not ensure delivery of a message to the User Agent at this time, we should only return 201 (as per the RFC). We cannot ensure end-to-end delivery because our system relies on using third party delivery systems for mobile devices which also do not provide this capability. |
Seems like this has already been addressed, but just for posterity wanted to answer this question:
The push RFC defines only 201 and 202 as valid successful response codes when sending a push message. 201 seems to be the expectation when not requesting receipts. Thanks all. |
FWIW, I want to thank you for being one of the very few folk that actually pay attention to the response codes we provide. |
Hah, of course. I'm appreciative with how open the Mozilla push implementation is and how easy it is to provide that feedback in the first place. Thanks for addressing the issue so quickly. |
Hello,
We have been seeing a lot (10s of thousands) of
200 OK
response codes from sending push messages to firefox users. Here's an example response with the location header obfuscated.Based on the response headers, it seems that nginx might be rewriting the response code.
cc @chamons
┆Issue is synchronized with this Jira Task
The text was updated successfully, but these errors were encountered: